e2e: follow HTTP redirects when fetching apt repo keys. #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
requested review from
askervin,
ipuustin,
kad,
marquiz and
mythi
as code owners
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
=======================================
Coverage 37.70% 37.70%
=======================================
Files 53 53
Lines 7877 7877
=======================================
Hits 2970 2970
Misses 4631 4631
Partials 276 276 Continue to review full report at Codecov.
|
askervin
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
LGTM. Works fine.
Note (to self, at least): there's a warning at least on distro=debian-sid:
root@vm> curl -L -s https://download.docker.com/linux/debian/gpg | apt-key add -
Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
...but that's not a problem of this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply fetch keys with
curl -Linstead of plaincurl.